Repository navigation
fix(releases): Default deploy dateFinished to now when null - #127563
Merged
Merged
Conversation
The deploy create endpoint accepts an explicit null dateFinished, but create_deploy only applied the now() default when the key was absent, so null reached the NOT NULL date_finished column and raised an IntegrityError (500). Fixes SENTRY-5PDF Fixes REL-25 Co-Authored-By: Saraj Manes <saraj.manes@sentry.io>
manessaraj
requested review from
a team and
manessaraj
and removed request for
a team
October 15, 2026 16:24
wmak
approved these changes
Oct 15, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /api/0/organizations/{org}/releases/{version}/deploys/accepts"dateFinished": null(the serializer field isallow_null=Trueand documented as defaulting to the current time), butcreate_deployusedresult.get("dateFinished", timezone.now()), which only applies the default when the key is absent. An explicit null went straight into the NOT NULLdate_finishedcolumn and the request 500'd with anIntegrityError.Treat null the same as omitted, and add a test that posts an explicit null.
Fixes SENTRY-5PDF
Fixes REL-25
via Saraj Manes.
--
View Junior Session in Sentry